Fix python2 build under OpenWrt 21.02 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openwrt/packages#14044 (comment) Signed-off-by: Pavel Krotkiy <[email protected]>
|
Why open a PR for abandoned packages? |
|
We can consider this a backport. I suppose there are still many utilities using python 2, so it seemed appropriate to me. Close PR please, if I'm wrong |
|
This is the abandoned feed not the packages feed. Anything you do here has no effect on OpenWrt packages. I think what you're looking to do is edit branch 21.02 in the packages feed. |
|
In upstream feed (openwrt/packages) python2 declared as deprecated and I can't make PR into it. In my build I use this feed to compile python2 and py2 modules |
|
openwrt/packages#14073 is the change you want to backport. |
|
@Porsh33 you can make a PR against the 19.07 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to openwrt/packages#14044 (comment)