fix critical issue: parsing messages with image_url #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
I've experienced issue while using the #openai-php/laravel repo which depends on this repo.
The issue was related to messages with content type image_url instead of image_file. Parsing this type of file within the current structure of the project is wrong. I assume it's copy/paste issue because the structure of the classes that parse image_file response was the same as these for image_url response.
With the current PR I'm solving this issue.
Here is the API reference:
https://platform.openai.com/docs/api-reference/messages/createMessage#messages-createmessage-content
Related:
#456
openai-php/laravel#107
openai-php/laravel#116