Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting per-request custom metrics in gRPC stats handler. #6092

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dhowden
Copy link

@dhowden dhowden commented Sep 5, 2024

Updates #6026, similar to #5876 but for gRPC.

Copy link

linux-foundation-easycla bot commented Sep 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (8a49875) to head (b474ced).

Files with missing lines Patch % Lines
...entation/google.golang.org/grpc/otelgrpc/config.go 0.0% 5 Missing ⚠️
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 0.0% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6092     +/-   ##
=======================================
- Coverage   65.7%   65.7%   -0.1%     
=======================================
  Files        203     203             
  Lines      13037   13044      +7     
=======================================
+ Hits        8568    8570      +2     
- Misses      4206    4212      +6     
+ Partials     263     262      -1     
Files with missing lines Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 96.6% <0.0%> (-3.4%) ⬇️
...entation/google.golang.org/grpc/otelgrpc/config.go 85.8% <0.0%> (-4.3%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants