Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oscisgen-start 6.3.0: remove upper bound on eliom to force CI tests #25604

Closed
wants to merge 1 commit into from

Conversation

mseri
Copy link
Member

@mseri mseri commented Mar 29, 2024

Due to the erroneous merge of #25579
Ping @balat

@mseri
Copy link
Member Author

mseri commented Apr 3, 2024

@balat the CI looks mostly fine. The only failures are due to ocsigen-toolkit and are all of the type

# File "_none_", line 1:
# Error: Cannot load js_of_ocaml-ppx_deriving_json: this object file uses
#        unsafe features

@balat
Copy link
Contributor

balat commented Apr 3, 2024

Yes we have this every time. We should try to fix this in toolkit.

@balat
Copy link
Contributor

balat commented Apr 3, 2024

I opened an issue on Ocsigen Toolkit ocsigen/ocsigen-toolkit#230
This should not block this PR

@mseri
Copy link
Member Author

mseri commented Apr 5, 2024

Can I merge the relaxed upper bound or should I close this PR?

@balat
Copy link
Contributor

balat commented Apr 5, 2024

Oh yes this one was only for testing sorry, and the other one is already merged.
You can close. Thank you!

@mseri mseri closed this Apr 5, 2024
@mseri mseri deleted the mseri-patch-4 branch July 1, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants