Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAQ v1 fixes + initial OpenAQ v2 reader #141

Merged
merged 82 commits into from
Sep 19, 2024
Merged

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Oct 26, 2023

Closes #130 #122

@zmoon zmoon marked this pull request as ready for review September 11, 2024 21:25
Copy link
Member

@bbakernoaa bbakernoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just make sure we document where to receive the API key

@zmoon
Copy link
Member Author

zmoon commented Sep 19, 2024

Thanks @bbakernoaa . I have this automatic warning set up:

if API_KEY is None:
warnings.warn(
"Non-cached requests to the OpenAQ v2 web API will be slow without an API key, "
"or might fail (HTTP error 401). "
"Obtain one (https://docs.openaq.org/docs/getting-started#api-key) "
"and set your OPENAQ_API_KEY environment variable.",
stacklevel=2,
)
but I will also add the relevant info to the module docstring.

@zmoon zmoon merged commit 8f981eb into noaa-oar-arl:develop Sep 19, 2024
7 checks passed
@zmoon zmoon deleted the openaq branch September 19, 2024 19:13
@zmoon zmoon mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants