Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Attribute Support for ZeroLog #935

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mirackara
Copy link
Contributor

Links

Details

@iamemilio
Copy link
Contributor

iamemilio commented Aug 29, 2024

I think this will work with simple attributes like strings or numbers, but what about maps, or slices? I think that is a weakness of this library in general. It needs to be able to parse a lot of complex objects, and the token that seperates them is configurable in zerolog. See my risk matrix item for more info. Before we spend more time here, I might recommend another re-write.

@nr-swilloughby
Copy link
Contributor

I think this will work with simple attributes like strings or numbers, but what about maps, or slices? I think that is a weakness of this library in general. It needs to be able to parse a lot of complex objects, and the token that seperates them is configurable in zerolog. See my risk matrix item for more info. Before we spend more time here, I might recommend another re-write.

I agree. This is definitely a concern about the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants