Feat/ts on tests #142
Merged
Feat/ts on tests #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will create a separate pull request on top of this to add a test for #141 |
rvagg
approved these changes
Jan 4, 2022
rvagg
force-pushed
the
feat/ts-on-tests
branch
from
5133a29
to
4f4d00a
Compare
|
🎉 This PR is included in version 9.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables TS on tests. Did that because as I was trying to figure out #141 I did notice that some type inference degraded, which is unsurprising if we are not verifying things.
This pull also fixes b32 types and adds some tests to ensure that inference works as expected.