Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Provide Support for Socket IO Protocol V5 #909

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

iHDeveloper
Copy link

@iHDeveloper iHDeveloper commented Jun 16, 2023

Hello, I'm planning to use Netty Socket IO server in production but was unable to use it with the official javascript client due to not supporting protocol version 5 of Socket IO. I didn't knew it didn't support it until I tested the namespace connect event not being fired on the client side. I was quite shocked this library exists since 2013 and the Socket IO don't have it referenced in the language SDKs list.

I'm writing this PR as a draft to get a permission from the author of the repository @mrniko to continue writing the patch for this PR.

The checklist for this PR to keep things clear and easy to track:

Source

Thank you for your time reading and checking this PR out and have a great day.
God knows best.

- Missing the `,` separator during an encoding of a namespace packet
- Invalid connect packet being sent after connect listeners executed
Any clients who didn't join the default namespace wouldn't be able to have their packets processed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant