[date] Update to HEAD versioning #39465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangWeiLin-MV
added
the
category:port-update
|
Please check the pipeline logs here or download the logs failure logs for arm64-uwp.zip and failure logs for x64-uwp.zip |
TheStormN
approved these changes
Jun 24, 2024
|
I updated the UWP patch for the new version. I want to submit this to upstream, but I need to verify it works first (I don't have a Windows dev environment). |
BillyONeal
reviewed
Jun 25, 2024
| using co_task_mem_ptr = std::unique_ptr<wchar_t[], task_mem_deleter>; | ||
| } | ||
|
|
||
| -static |
There was a problem hiding this comment.
How does moving this function down fix UWP?
There was a problem hiding this comment.
It was moved out the #ifdef !WINRT section so it compiles also on UWP.
|
Thanks for the update! |
WangWeiLin-MV
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintainer of the
datelibrary highly recommends to use "live at head" versioning. The library hasn't had a proper release in three years, and the lastest one doesn't work with modern compilers (for example Apple Clang 15). There is only one final release planned for next week, so I think it would be preferable to switch to head versioning to make sure any improvements pass this last release can still be included in the vcpkg port../vcpkg x-add-version --alland committing the result.