Feature/project description #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Ulbrich <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
.run/single-binary.run.xml
Outdated
Comment on lines
12
to
13
| </component> No newline at end of file | ||
| </component> |
There was a problem hiding this comment.
Where does this change come from?
There was a problem hiding this comment.
Automatically changed from IntelliJ
cmd/single/start.go
Outdated
Comment on lines
75
to
79
| projects := []config.Project{{Name: "flytesnacks", Description: "flytesnacks project"}} | ||
| if len(cfg.SeedProjects) > 0 { | ||
| for _, project := range cfg.SeedProjects { | ||
| projects = append(projects, config.Project{Name: project.Name, Description: project.Description}) | ||
| } |
There was a problem hiding this comment.
AFAIK it will keep "flytesnacks" even if someone defines his/her own projects, right? Previoulsy it wasn't the case
There was a problem hiding this comment.
You are right, I have fixed it
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
Signed-off-by: Ulbrich Robert <[email protected]>
LucasZanellaMBTI
approved these changes
Sep 16, 2024
| @@ -73,7 +73,7 @@ func Test_tokenEndpoint(t *testing.T) { | |||
|
|
|||
| m := map[string]interface{}{} | |||
| assert.NoError(t, json.Unmarshal(rw.Body.Bytes(), &m)) | |||
| assert.Equal(t, 0.5*time.Hour.Seconds()-1, m["expires_in"]) | |||
| assert.GreaterOrEqual(t, m["expires_in"], 0.5*time.Hour.Seconds()-5) | |||
There was a problem hiding this comment.
Personally I would separate this using a dedicated fix but not sure if flyte guys care about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This change allows to set the description of a Flyte project. It could hold the responsible team for a Flyte project including the contact data or some other information.
What changes were proposed in this pull request?
flyte-coreHelm chart so they can hold a name and a description for the projectflyte-binaryand the single binary approach the structure of the Helm chart was changedHow was this patch tested?
flyteadmin migrate seed-projectswas tested with the adaptedflyte-single-binary-local.yamlconfig fileSetup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link