Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex-shrink: add description and detailed example #34420

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 26, 2024

this is a complex property, but had little explanation.

updating guide as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 26, 2024 07:53
@estelle estelle requested review from chrisdavidmills and removed request for a team June 26, 2024 07:53
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jun 26, 2024
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
@estelle estelle mentioned this pull request Jun 26, 2024
29 tasks
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Preview URLs

(comment last updated: 2024-06-27 14:32:03)

estelle and others added 2 commits June 26, 2024 00:56
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jun 26, 2024
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle nice work! I've just got a few suggestions for you to go through.

files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/flex-shrink/index.md Outdated Show resolved Hide resolved
Copy link
Member Author

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills thank you. Committed all your suggestions.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go gogo gogoooooooooooo!

@chrisdavidmills chrisdavidmills merged commit 62826d2 into main Jun 27, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the estelle-patch-3 branch June 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants