change dataSource to datasource #10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8738018459Details
💛 - Coveralls |
warisniz02
force-pushed
the
fix/datasource-consistency
branch
2 times, most recently
from
6a4d7fc
to
d2d223f
Compare
|
@dhmlau please have a look at my PR. |
warisniz02
force-pushed
the
fix/datasource-consistency
branch
from
6f19bce
to
347337b
Compare
aaqilniz
approved these changes
May 8, 2024
|
Hello @samarpanB. Can you please have a look at this PR? |
samarpanB
requested changes
Jul 12, 2024
docs/site/Discovering-models.md
Outdated
| @@ -35,7 +35,7 @@ Models can be discovered from a supported datasource by running the | |||
|
|
|||
| ### Options | |||
|
|
|||
| `--dataSource`: Put a valid datasource name here to skip the datasource prompt | |||
| `--datasource`: Put a valid datasource name here to skip the datasource prompt | |||
There was a problem hiding this comment.
Rather than replacing the old prompt, can we not support both old and new. This will ensure backward compatibility. Otherwise it will break existing cli command.
warisniz02
force-pushed
the
fix/datasource-consistency
branch
from
8f67a50
to
2fd6fc8
Compare
warisniz02
force-pushed
the
fix/datasource-consistency
branch
3 times, most recently
from
9ec6487
to
28c7c11
Compare
warisniz02
force-pushed
the
fix/datasource-consistency
branch
2 times, most recently
from
564fb5e
to
ade4914
Compare
aaqilniz
approved these changes
Aug 22, 2024
|
@samarpanB please have a look at my PR! |
samarpanB
requested changes
Aug 27, 2024
| if ( | ||
| this.dataSourceChoices | ||
| .map(d => d.name) | ||
| .includes(this.options.dataSource) | ||
| .includes(this.options.dataSource || this.opetions.datasource) |
There was a problem hiding this comment.
Suggested change
| .includes(this.options.dataSource || this.opetions.datasource) | |
| .includes(this.options.dataSource || this.options.datasource) |
There was a problem hiding this comment.
Resolved!! @samparanB, please have a look at my PR now!!
warisniz02
force-pushed
the
fix/datasource-consistency
branch
from
a6d5c6d
to
1162e49
Compare
Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]> Signed-off-by: warisniz02 <[email protected]>
warisniz02
force-pushed
the
fix/datasource-consistency
branch
from
1162e49
to
4657666
Compare
samarpanB
approved these changes
Sep 1, 2024
|
one of the test case is failing |
samarpanB
reviewed
Sep 1, 2024
|
@samarpanB, this test case fails in every PR. This PR is to fix this issue( |
|
There seems to be some issue with the setup-node GH action, and not related to the changes introduced in this PR. So I'm going to merge this PR. |
|
@warisniz02, thanks for your contribution. Your PR has been merged! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lb4 discoverernames the argument to pass datasource as "dataSource". This PR makes the argument consistent with thelb4 datasourcewithout breaking existing cli command 'lb4 dataSource'.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈