Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs blog readme #7953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix docs blog readme #7953

wants to merge 1 commit into from

Conversation

AnshumanTripathi
Copy link

Which issue(s) this PR fixes:

Fixes # #7952

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @AnshumanTripathi!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AnshumanTripathi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mengjiao-liu
mengjiao-liu reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@mengjiao-liu mengjiao-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2024
mengjiao-liu
mengjiao-liu reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@mengjiao-liu mengjiao-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@mengjiao-liu
Copy link
Member

/assign @reylejano

@k8s-ci-robot
Copy link
Contributor

@lavishpal: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

divya-mohan0209
divya-mohan0209 suggested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use relative linking please instead of specifying the entire link?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@AnshumanTripathi
Copy link
Author

Can we use relative linking please instead of specifying the entire link?

I have updated to use the relative but we use the complete URL in other places, for example -

community/sig-docs/README.md

Lines 106 to 107 in 384d42f

[subproject-definition]: https://github.com/kubernetes/community/blob/master/governance.md#subprojects
[working-group-definition]: https://github.com/kubernetes/community/blob/master/governance.md#working-groups
. Should I update the other references under sig-docs as well?

@stmcginnis
Copy link
Contributor

Should I update the other references under sig-docs as well?

That would be great - whether here or in another PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnshumanTripathi, lavishpal
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2024
@AnshumanTripathi
Copy link
Author

Should I update the other references under sig-docs as well?

That would be great - whether here or in another PR.

/lgtm

Actually this might not be possible since the generator expects complete links.

@AnshumanTripathi
Fix docs blog readme
30497ed 
Signed-off-by: Anshuman Tripathi <[email protected]>

Use relative link

Signed-off-by: Anshuman Tripathi <[email protected]>

Revert "Use relative link"

This reverts commit 02a9f8d.

Use relative link

Signed-off-by: Anshuman Tripathi <[email protected]>

Update sig-docs readme

Signed-off-by: Anshuman Tripathi <[email protected]>

Revert "Update sig-docs readme"

This reverts commit 60b0f79.

Fix readme through sigs.yaml

Signed-off-by: Anshuman Tripathi <[email protected]>
reylejano
reylejano reviewed Jul 23, 2024
View reviewed changes
sig-docs/README.md
Comment on lines +102 to +104
### subproject-definition
- **Owners:**
- [kubernetes/community/governance.md#subprojects](https://github.com/kubernetes/community/blob/master/governance.md#subprojects)
Copy link
Member

@reylejano reylejano Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This area is a list of SIG Docs subprojects: blog, localization, reference-docs, website
I don't think the subproject and WG definition belongs here.

I think this place is better for the link to the subproject definition if it's not there
https://github.com/kubernetes/community/blob/master/governance.md#subprojects

reylejano
reylejano reviewed Jul 23, 2024
View reviewed changes
sigs.yaml
Comment on lines +1672 to +1680
- name: subproject-definition
owners:
- https://raw.githubusercontent.com/kubernetes/community/master/governance.md#subprojects
- name: website
owners:
- https://raw.githubusercontent.com/kubernetes/website/master/OWNERS
- name: working-group-definition
owners:
- https://raw.githubusercontent.com/kubernetes/community/master/governance.md#working-groups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This area has SIG Docs named subprojects: blog, localization, reference-docs, website
The links to the definition of subproject and WG does not belong here

reylejano
reylejano reviewed Jul 23, 2024
View reviewed changes
sig-docs/README.md
Comment on lines +108 to +110
### working-group-definition
- **Owners:**
- [kubernetes/community/governance.md#working-groups](https://github.com/kubernetes/community/blob/master/governance.md#working-groups)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this place is better for the link to the WG definition if it's not there
https://github.com/kubernetes/community/blob/master/governance.md#working-groups

This area is for named SIG Docs subprojects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengjiao-liu mengjiao-liu mengjiao-liu left review comments

@reylejano reylejano reylejano left review comments

@lavishpal lavishpal lavishpal approved these changes

@salaxander salaxander Awaiting requested review from salaxander

@tengqm tengqm Awaiting requested review from tengqm

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@stmcginnis stmcginnis

@mengjiao-liu mengjiao-liu

@reylejano reylejano

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AnshumanTripathi @k8s-ci-robot @mengjiao-liu @stmcginnis @divya-mohan0209 @reylejano @lavishpal