Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing multiple arguments in test_args #118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

m-fila
Copy link

@m-fila m-fila commented Aug 13, 2024

Passing multiple test_args is a feature in Pkg.test but the action input test_argsadded in #73 allows only a single argument.
Parsing the test_args with julia is added to allow passing multiple args in test_args (as in #73 (comment))

Usage example m-fila/Example.jl#1 and CI check https://github.com/m-fila/Example.jl/pull/1/checks#step:6:61

Closes #47

@m-fila m-fila requested a review from a team as a code owner August 13, 2024 07:21
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53f7ca9) to head (3c62a77).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! I was just thinking of making a PR like this myself, thanks @m-fila!

I had a couple of small proposals for improvements. Note that I'm just a passer-by, I have no admin rights on the repo.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@m-fila
Copy link
Author

m-fila commented Sep 11, 2024

@IanButterworth is there anything blocking this? I'm pinging you since you merged the original PR adding test_args #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass custom arguments?
2 participants