fix: 🐛 ignore parallelism of 1

joscha · Oct 22, 2019 · f2645da · f2645da · joscha · Oct 22, 2019
1 parent 16e4c61
commit f2645da
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/src/__tests__/__snapshots__/command.spec.ts.snap b/src/__tests__/__snapshots__/command.spec.ts.snap
@@ -389,6 +389,18 @@ subgraph cluster_0 {
 "
 `;
 
+exports[`buildkite-graph Steps Command parallelism dot 2`] = `
+"digraph \\"whatever\\" {
+  graph [ compound =true ];
+subgraph cluster_0 {
+  graph [ color = \\"black\\" ];
+  \\"<noop>\\" [ color = \\"grey\\" ];
+}
+
+}
+"
+`;
+
 exports[`buildkite-graph Steps Command parallelism json 1`] = `
 Object {
   "steps": Array [
@@ -400,13 +412,29 @@ Object {
 }
 `;
 
+exports[`buildkite-graph Steps Command parallelism json 2`] = `
+Object {
+  "steps": Array [
+    Object {
+      "command": "noop",
+    },
+  ],
+}
+`;
+
 exports[`buildkite-graph Steps Command parallelism yaml 1`] = `
 "steps:
   - command: noop
     parallelism: 123
 "
 `;
 
+exports[`buildkite-graph Steps Command parallelism yaml 2`] = `
+"steps:
+  - command: noop
+"
+`;
+
 exports[`buildkite-graph Steps Command plugins dot 1`] = `
 "digraph \\"whatever\\" {
   graph [ compound =true ];

diff --git a/src/__tests__/command.spec.ts b/src/__tests__/command.spec.ts
@@ -185,13 +185,16 @@ describe('buildkite-graph', () => {
                 ),
             );
 
-            createTest('parallelism', () =>
+            createTest('parallelism', () => [
                 new Pipeline('whatever').add(
                     new CommandStep('noop')
                         .withParallelism(100)
                         .withParallelism(123),
                 ),
-            );
+                new Pipeline('whatever').add(
+                    new CommandStep('noop').withParallelism(1),
+                ),
+            ]);
 
             createTest('plugins', () =>
                 new Pipeline('whatever').add(

diff --git a/src/steps/command.ts b/src/steps/command.ts
@@ -229,7 +229,7 @@ export class CommandStep extends LabeledStep {
             command: transformCommand(this.command),
             env: await (this.env as KeyValueImpl<this>).toJson(),
             id: this._id,
-            parallelism: this.parallelism,
+            parallelism: this.parallelism === 1 ? undefined : this.parallelism,
             concurrency: this.concurrency,
             concurrency_group: this.concurrencyGroup,
             artifact_paths: this._artifactPaths.size