Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add useRedisSets option #855

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Conversation

chrisllontop
Copy link
Contributor

@chrisllontop chrisllontop commented Jun 22, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f57309f) 100.00% compared to head (7aa2dd9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2541      2573   +32     
  Branches       328       335    +7     
=========================================
+ Hits          2541      2573   +32     
Impacted Files Coverage Δ
packages/redis/src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray
Copy link
Owner

@christianllv - can you add into the README the new option and what does it do?

@jaredwray
Copy link
Owner

Also, will we be able to support setting this option on the main Keyv such as this:

const keyv = new Keyv('redis://user:pass@localhost:6379', {useRedisSets: false});

I would also assume that by default we are using the Redis Sets to make sure this is backwards compatible?

@chrisllontop
Copy link
Contributor Author

Hello @jaredwray we are using only sets (without sadd) only when useredisSets is true. But, by default is false. Should I set useRedisSets in true by default?

@chrisllontop
Copy link
Contributor Author

chrisllontop commented Jun 23, 2023

Also, yes we can use that option in keyv

@jaredwray
Copy link
Owner

Hello @jaredwray we are using only sets (without sadd) only when useredisSets is true. But, by default is false. Should I set useRedisSets in true by default?

I am thinking for backwards compatibility we keep have useRedisSets to true as that is what it is today.

@jaredwray
Copy link
Owner

Also, yes we can use that option in keyv

Can you update the Redis README with this new option and examples?

@chrisllontop
Copy link
Contributor Author

@jaredwray docs added. Please take a look. Thanks!

packages/redis/README.md Show resolved Hide resolved
packages/redis/README.md Show resolved Hide resolved
@jaredwray jaredwray merged commit 5898932 into jaredwray:main Jun 26, 2023
7 checks passed
@chrisllontop chrisllontop deleted the fix/redis-namespace branch June 26, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants