Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor validateLangTag #23

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Oct 12, 2023

Description

Linked Issues

Additional context

@kazupon kazupon added the improvement Includes backwards-compatible fixes label Oct 12, 2023
@@ -0,0 +1,3 @@
declare namespace Intl {
function getCanonicalLocales(locales: string | string[]): string[]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curretnly, Intl.getCanonicalLocales is type ineffective in typescript
So, I used shim to work around it. Maybe send a PR to TypeScript.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazupon kazupon merged commit e72cc8b into main Oct 12, 2023
4 checks passed
@kazupon kazupon deleted the fix/refactor-locale-validation branch October 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant