Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to userland promises when executing for @inngest/test #710

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Sep 12, 2024

Summary

For @inngest/test (#704), we need access to the internal promise that we send to userland code so that we can access its output for state assertions.

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests N/A
  • Added changesets if applicable

Related

@jpwilliams jpwilliams self-assigned this Sep 12, 2024
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: e47ef75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Sep 12, 2024
@jpwilliams jpwilliams merged commit fc3f1e5 into main Sep 12, 2024
50 of 52 checks passed
@jpwilliams jpwilliams deleted the test/allow-userland-promise-access branch September 12, 2024 19:11
jpwilliams pushed a commit that referenced this pull request Sep 12, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#710](#710)
[`fc3f1e5`](fc3f1e5)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Allow access to
userland promises when executing for `@inngest/test`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants