Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.html #908

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2020

Added Bootstrap for better view. Assigned container class for margin and padding along the borders and made the site page responsive using vw.

Added Bootstrap for better view. Assigned container class for margin and padding along the borders and made the site page responsive using vw.
@@ -4,10 +4,12 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Hoodie</title>
<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css" integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way that you can reference the files locally?
By referencing an external website, you are creating a dependency for an internet connection to get the relevant styles on load.

<link rel="stylesheet" type="text/css" href="style.css">
</head>
<body>
<h1>Well done, you made it!</h1>
<div class="container" style="font-size:2.5vw;">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not use inline style attributes on elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant