Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify deployment with nginx #36

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: simplify deployment with nginx #36

wants to merge 12 commits into from
+82 −92

Conversation

veryCrunchy
Copy link
Contributor

@veryCrunchy veryCrunchy commented Sep 20, 2024 •
edited
Loading

This PR fixes:

Note

love with livekit will be implemented in a separate pr after this one has been merged

@veryCrunchy veryCrunchy marked this pull request as draft September 20, 2024 02:11
aonnikov
aonnikov reviewed Sep 20, 2024
View reviewed changes
nginx/setup.sh

read -p "Do you want to run 'docker compose up -d' now to spin up Huly? ([Y]es/[n]o): " RUN_DOCKER
case "${RUN_DOCKER,,}" in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work for me. But I'm using zsh that has different syntax for lower case. I suggest to simplify options in the case to [yY] and [nN]. What do you think?

@veryCrunchy
Copy link
Contributor Author

@aonnikov you beat me to it, most of the fixes you just pushed I have laying unpushed on my machine 😅
It would have been nice to get a co-author on your commit, considering the issue was initially raised by me and has been fixed in this PR.

@aonnikov
Copy link
Member

@aonnikov you beat me to it, most of the fixes you just pushed I have laying unpushed on my machine 😅 It would have been nice to get a co-author on your commit, considering the issue was initially raised by me and has been fixed in this PR.

Fair enough, added you as a co-author (know, it is dirty but better than nothing). Much appreciate your contribution!

@veryCrunchy
Copy link
Contributor Author

@aonnikov there are a lot of duplicate env variables set in the compose.yml, LAST_NAME_FIRST under transactor for example.
Are they really all used?

@veryCrunchy
Copy link
Contributor Author

Finally achieved a working huly instance!!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aonnikov aonnikov aonnikov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veryCrunchy @aonnikov