Change PickFirstLeafLoadBalancer to only have 1 subchannel at a time #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if environment variable GRPC_SERIALIZE_RETRIES == true.
… flag every time.
…the logic to cancelScheduledTasks
ejona86
reviewed
Sep 12, 2024
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if (reconnectPolicy == null) { | ||
| reconnectPolicy = bkoffPolProvider.get(); |
There was a problem hiding this comment.
I see the field is initialized here, but it isn't ever cleared on success. InternalSubchannel does that in cancelReconnectTask().
There was a problem hiding this comment.
Added a clear in shutdownRemaining()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide behind environment variable GRPC_SERIALIZE_RETRIES
This is for testing with GMS core to see if they use the new PF with only 1 subchannel at a time trying to reconnect whether that eliminates their 6% data increase.