Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rlwrap in the base image #1412

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Include rlwrap in the base image #1412

merged 2 commits into from
Sep 4, 2024

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Sep 3, 2024

Description

For some reason, rlwrap is not being properly being set up and breaking apt upgrade. We include it now in the base image to hotfix the issue. This is more of a band-aid fix, and we should look into figuring it out properly.

Related Issue(s)

Fixes ENT-751

How to test

From Filip's 100% trustworthy Docker Hub entry

  1. Create a workspace (either a full new one or a gp validate "debug" one) based off of filiptronicek/workspace-full:rlwrap
  2. Make sure you can execute sudo apt update && sudo apt upgrade in the newly-created workspace

From source

Beware, this will take a while

  1. Open this repo in a workspace
  2. ./build-combo.sh full
  3. docker pull localhost:5000/dazzle:full
  4. Create a .gitpod.yml file in an example folder in the repo root
  5. gp validate --workspace-folder="/workspace/workspace-images/example"
  6. Make sure you can execute sudo apt update && sudo apt upgrade in the newly-created workspace

@filiptronicek filiptronicek requested review from a team as code owners September 3, 2024 07:19
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I performed the "From Filip's 100% trustworthy Docker Hub entry" test and it worked ✔️

Not sure what the build issue is about 🤷

@filiptronicek
Copy link
Member Author

I think we're bumping into castwide/solargraph#706

@filiptronicek
Copy link
Member Author

Trying to conditionally get rid of this dependency in #1413

@filiptronicek filiptronicek mentioned this pull request Sep 4, 2024
@filiptronicek filiptronicek enabled auto-merge (squash) September 4, 2024 11:23
@filiptronicek filiptronicek merged commit c922c6e into main Sep 4, 2024
4 checks passed
@filiptronicek filiptronicek deleted the ft/base-rlwrap branch September 4, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants