Failing unit test for Autolinks sync #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No modifications are made if the number of existing and configured autolinks is equal
stevoland
commented
Aug 21, 2023
Comment on lines
+32
to
+34
| { id: '1', key_prefix: 'SAME-', url_template: 'https://same/<num>', is_alphanumeric: true }, | ||
| { id: '2', key_prefix: 'REMOVE-', url_template: 'https://test/<num>', is_alphanumeric: true }, | ||
| { id: '3', key_prefix: 'NEW_URL-', url_template: 'https://old-url/<num>', is_alphanumeric: true }, |
There was a problem hiding this comment.
Remove any line for the test to pass
Closed
|
resolved the merge conflicts in #598 but seeing the tests fail. Need to spend a little bit more time to resolve this. |
|
@stevoland Seems like the later PRs resolved this. I think we can close this without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No modifications are made if the number of existing and configured autolinks is equal.
Seems to be a conflict in the mergeDeep behaviour with the other plugins. Removing the condition around this line fixes it https://github.com/github/safe-settings/blob/main-enterprise/lib/mergeDeep.js#L88
As a side note, currently 18 unit tests are failing (hopefully because they have become incorrect). Running the tests on CI should be a priority. The failing tests can be skipped and fixed incrementally. I'm happy to contribute to getting the the above PR merged.
Thanks