Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1434 adding test for type ahead request at a view port level #1465

Merged
merged 10 commits into from
Aug 20, 2024
Merged

#1434 adding test for type ahead request at a view port level #1465

merged 10 commits into from
Aug 20, 2024

Conversation

naleeha
Copy link
Contributor

@naleeha naleeha commented Aug 20, 2024

#1434 adding test for type ahead request at a view port level.

  • Using DefaultRpcHandler - new approach the register the Rpc function handler rather than match based on method and parameter on Service/RpcHandler class
  • Building out the web socket api testing
    • Data is loaded into table at initialisation

Work in progress

  • Java example of PersonRpcHandler that uses register Rpc function
  • Change for type ahead request to apply to view port column rather than table column

@naleeha
finos#1434 adding java example for implementing custom rpc handler fo…
ee9fe69 
…r the view port - work in progress
@naleeha
finos#1434 replacing the RpcMethodHandler object with at type alias
6332db4
@naleeha
finos#1434 adding test for type ahead request at a view port level. D…
e20955d 
…ata is loaded into table at initialisation
@naleeha
finos#1434 adding test for type ahead request with start string. Maki…
ec676f0 
…ng rpc function names typed and in separate files to make it easier to find as public api
@naleeha
finos#1434 separating web socket api tests to logical test suits with…
81f71a9 
… their own table and module definitions
@naleeha
finos#1434 cleanup
18b6e8e
@naleeha
finos#1434 assert that only top 10 unique values are returned for typ…
8c875d6 
…eahead request
@naleeha
finos#1434 fix the logging around rpc handlers to log the correct act…
084b52b 
…ions its performing
@naleeha
finos#1434 edge and error case tests for typeahead on view port
655a91f
@naleeha
finos#1434 fixing default rpc handler to be able to return success re…
3c6102d 
…sult with no result as well as with result
@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit 3c6102d
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/66c460feeae0860008ea298f

@keikeicheung keikeicheung merged commit 5571459 into finos:main Aug 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naleeha @keikeicheung