-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): allow pods mixte type settings on post-install #46536
Conversation
Hi @MasGaNo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 😄
@MasGaNo could you sign the CLA? otherwise I can't import it in the internal repository |
Hey @cipolleschi I already signed it 😄 Edit: Ah... but it's still red... Let me check Is it the only action to do? |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cipolleschi merged this pull request in 1e59f2e. |
This pull request was successfully merged by @MasGaNo in 1e59f2e When will my fix make it into a release? | How to file a pick request? |
Summary:
Following the discussion on #46505, this PR aims to allow mixte type configuration (String and/or Array of String) during the post installation of pods.
Changelog:
[IOS] [FIXED] - allow pods mixte type settings on post-install
Test Plan:
packages/react-native/scripts/cocoapods/__tests__/utils-test.rb
test suits was updated to support array and works as expected