AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction #6

forshtat · 2024-08-13T12:31:06Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

ERCS/erc-xxxx.md

Co-authored-by: shahafn <[email protected]>

drortirosh

wrong base, so it suggest modifications for many files.
I think it should be dropped, and instead, commit first against our internal document - and from there, push it to the public repo
(at a minimum: make sure you commit a single file.)

drortirosh · 2024-08-15T08:30:10Z

ERCS/erc-xxxx.md

@@ -0,0 +1,375 @@
+---
+eip: xxxx
+title: JSON-RPC API for RIP-7560 Native Account Abstraction


Native AA Transaction

API exposed by NODE

ERCS/erc-xxxx.md

drortirosh · 2024-08-15T08:33:19Z

ERCS/erc-xxxx.md

+
+## Motivation
+
+Native Account Abstraction is expected to supersede the [ERC-4337](https://eips.ethereum.org/EIPS/eip-4337)


we don't motivation for AA here. that's in 7560.

ERCS/erc-xxxx.md

drortirosh · 2024-08-15T09:27:57Z

ERCS/erc-xxxx.md

+| executionGasUsed           | QUANTITY        | The amount of gas actually used by the execution frame                         |
+| postOpStatus               | QUANTITY        | 1 (success), 0 (failure), or `null` (did not run) status of the `postOp` frame |
+| postOpGasUsed              | QUANTITY        | The amount of gas actually used by the paymaster `postOp` frame                |
+| validationLogs             | ARRAY           | Array of log objects, which this transaction'S VALIDATION FRAME generated.     |


That's interesting.
its a way to report back events but not through a separate "pseudo tx".
still, I think that on-chain, it is a separate tx (e.g the txhash reported in each event)

We have discussed it and did not really reach consensus on how to present the validation phase through an RPC API. However, a separate transaction for a part of a transaction is a very breaking change and should be made very carefully.

ERCS/erc-xxxx.md

…on' result schema

ERCS/erc-xxxx.md

drortirosh · 2024-09-10T12:56:27Z

ERCS/erc-xxxx.md

+| Name                       | Type           | Description                                                                    |
+|----------------------------|----------------|--------------------------------------------------------------------------------|
+| sender                     | DATA, 20 Bytes | Address of the sender of this transaction                                      |
+| paymaster                  | DATA, 20 Bytes | Address of the Paymaster if it is paying for the transaction, `null` otherwise |


put all paymaster fields together: if paymaster exists, then all other paymaster fields MUST exist.
if paymaster is missing, then all others MUST NOT exist

ERCS/erc-xxxx.md

shahafn · 2024-09-10T13:36:54Z

ERCS/erc-xxxx.md

+
+### Add RIP-7560 support for `eth_getTransactionReceipt`
+
+For an RIP-7560 transaction included in a block, return also the values specific to this transaction type


Move Receipt back to 7560

shahafn · 2024-09-10T13:37:47Z

ERCS/erc-xxxx.md

+
+### Add RIP-7560 support for all remaining transaction-level RPC APIs
+
+This includes the following APIs: `eth_sendTransaction`, `eth_sendRawTransaction`,  `eth_getTransactionByHash`,


Suggested change

This includes the following APIs: `eth_sendTransaction`, `eth_sendRawTransaction`, `eth_getTransactionByHash`,

This includes the following APIs: `eth_sendTransaction`, `eth_sendRawTransaction`, `eth_getTransactionByHash`, `eth_getTransactionReceipt`

drortirosh · 2024-09-10T13:42:23Z

ERCS/erc-xxxx.md

+### Add RIP-7560 support for all remaining transaction-level RPC APIs
+
+This includes the following APIs:
+`eth_sendTransaction`,


remove sendTransaction..
must use sendRawTransaction to send type-4 transaction
(account must do rlp encoding anyway, to sign)

drortirosh · 2024-09-10T13:51:15Z

ERCS/erc-xxxx.md

+| paymaster                     | DATA, 20 Bytes | Address of the Paymaster contract (optional)                                        |
+| paymasterData                 | DATA           | Data that is provided to the Paymaster contract (if `paymaster` is set)             |
+| executionData                 | DATA           | Data that is provided to the Account contract for execution                         |
+| nonce                         | QUANTITY       | A 256 bit nonce. Use of `nonce > 2^64` is defined in RIP-7712                       |


separate nonceKey field

shahafn · 2024-09-10T13:54:24Z

ERCS/erc-xxxx.md

+The following table represents a full list of fields of an RIP-7560 transaction:
+


Move to 7560 along with tx receipt

Co-authored-by: shahafn <[email protected]>

…ion`

shahafn · 2024-09-10T14:02:52Z

ERCS/erc-xxxx.md

+
+## Rationale
+
+### Creating `eth_executeRip7560Transaction` instead of modifying `eth_call`


Suggested change

### Creating `eth_executeRip7560Transaction` instead of modifying `eth_call`

### Creating `eth_callRip7560Transaction` instead of modifying `eth_call`

ERCS/erc-xxxx.md

forshtat · 2024-09-10T14:15:25Z

Closed in favour of ethereum#625

github-actions · 2024-09-10T14:21:41Z

The commit 237cd9a (as a parent of 5d375e6) contains errors.
Please inspect the Run Summary for details.

Initial commit

20300e8

github-actions bot added the w-ci label Aug 13, 2024

Initial addition of RIP-7560 specific JSON-RPC API methods

e63c1f9

forshtat changed the title ~~Create JSON-RPC API standard for RIP-7560 Native Account Abstraction~~ AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction Aug 13, 2024

Add some definitions

fae2ef6

shahafn reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

shahafn reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

Update erc-xxxx.md

75f5687

shahafn reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

forshtat and others added 3 commits August 15, 2024 12:00

Update ERCS/erc-xxxx.md

595eb7a

Co-authored-by: shahafn <[email protected]>

Update ERCS/erc-xxxx.md

be81528

Co-authored-by: shahafn <[email protected]>

Update ERCS/erc-xxxx.md

7aee678

Co-authored-by: shahafn <[email protected]>

github-actions bot added w-ci and removed w-ci labels Aug 15, 2024

Update erc-xxxx.md

8a469f7

drortirosh requested changes Aug 15, 2024

View reviewed changes

forshtat force-pushed the master branch from 6e97116 to 9f7e122 Compare August 15, 2024 11:53

forshtat added 2 commits August 15, 2024 13:57

Remove unnecessary list of existing transaction types

7907ef9

Fix reference to a removed method

aa361b3

github-actions bot added c-new s-draft t-erc labels Aug 15, 2024

Remove 'eth_signRip7560Transaction'; remove 'eth_traceRip7560Validati…

b48ec44

…on' result schema

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

Remove 'validationLogsBloom' field

7430b1e

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Show resolved Hide resolved

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

drortirosh reviewed Aug 15, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

forshtat marked this pull request as ready for review September 8, 2024 09:39

Remove unnecessary 'contractAddress' field

e4726c2

shahafn reviewed Sep 10, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

shahafn reviewed Sep 10, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

drortirosh reviewed Sep 10, 2024

View reviewed changes

shahafn reviewed Sep 10, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

forshtat added 2 commits September 10, 2024 15:08

Explain fields optionality

8cf51dd

Remove 'status', add 'executionStatus'

fff8372

shahafn reviewed Sep 10, 2024

View reviewed changes

Mmove the eth_getTransactionReceipt description to core RIP-7560

6d6ff43

github-actions bot removed the w-ci label Sep 10, 2024

drortirosh reviewed Sep 10, 2024

View reviewed changes

github-actions bot added the w-ci label Sep 10, 2024

drortirosh reviewed Sep 10, 2024

View reviewed changes

shahafn reviewed Sep 10, 2024

View reviewed changes

forshtat and others added 2 commits September 10, 2024 15:55

Remove transaction description table

1e71ff2

update title

8b0a2a7

Co-authored-by: shahafn <[email protected]>

github-actions bot removed the w-ci label Sep 10, 2024

shahafn and others added 2 commits September 10, 2024 17:00

Grammar

23855ad

Rename to eth_executeRip7560Transaction to `eth_callRip7560Transact…

4eaf77a

…ion`

shahafn reviewed Sep 10, 2024

View reviewed changes

Fix

8013ecf

drortirosh reviewed Sep 10, 2024

View reviewed changes

ERCS/erc-xxxx.md Outdated Show resolved Hide resolved

update call return value

237cd9a

shahafn approved these changes Sep 10, 2024

View reviewed changes

forshtat closed this Sep 10, 2024

github-actions bot added the w-ci label Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction #6

AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction #6

forshtat commented Aug 13, 2024

drortirosh left a comment

drortirosh Aug 15, 2024

drortirosh Aug 15, 2024

drortirosh Aug 15, 2024

drortirosh Aug 15, 2024

forshtat Aug 15, 2024

drortirosh Sep 10, 2024

shahafn Sep 10, 2024

shahafn Sep 10, 2024

drortirosh Sep 10, 2024

drortirosh Sep 10, 2024

shahafn Sep 10, 2024

shahafn Sep 10, 2024

forshtat commented Sep 10, 2024

github-actions bot commented Sep 10, 2024


		## Motivation

		Native Account Abstraction is expected to supersede the [ERC-4337](https://eips.ethereum.org/EIPS/eip-4337)


		### Add RIP-7560 support for `eth_getTransactionReceipt`

		For an RIP-7560 transaction included in a block, return also the values specific to this transaction type


		### Add RIP-7560 support for all remaining transaction-level RPC APIs

		This includes the following APIs: `eth_sendTransaction`, `eth_sendRawTransaction`, `eth_getTransactionByHash`,

		The following table represents a full list of fields of an RIP-7560 transaction:


		## Rationale

		### Creating `eth_executeRip7560Transaction` instead of modifying `eth_call`

	### Creating `eth_executeRip7560Transaction` instead of modifying `eth_call`
	### Creating `eth_callRip7560Transaction` instead of modifying `eth_call`

AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction #6

AA-416: Create JSON-RPC API standard for RIP-7560 Native Account Abstraction #6

Conversation

forshtat commented Aug 13, 2024

drortirosh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

forshtat commented Sep 10, 2024

github-actions bot commented Sep 10, 2024