Broken selectors after exactNode

[lukaw3d]

Add more tests for #145 that show these selectors do not work correctly

• :has(>BlockStatement>ExpressionStatement)
• :has(>BlockStatement ExpressionStatement)

but there are workarounds:

• :has(>BlockStatement:has(>ExpressionStatement))
• :has(>BlockStatement:has(ExpressionStatement))

[lukaw3d]

The cause seems to be that child selector (BlockStatement>ExpressionStatement) matches on the nested node (selector.right ExpressionStatement, instead of selector.left BlockStatement). Then exactNode checks if parent node has any ancestors

esquery/esquery.js

Line 205 in 07ee329

return left(ancestry[0], ancestry.slice(1), options);

esquery/esquery.js

Lines 130 to 133 in 07ee329

	case 'exactNode':
	return (node, ancestry) => {
	return ancestry.length === 0;
	};

within IfStatement:has(>BlockStatement>ExpressionStatement)

selector {
  type: 'child',
  left: { type: 'exactNode' },
  right: {
    type: 'child',
    left: { type: 'identifier', value: 'BlockStatement' },
    right: { type: 'identifier', value: 'ExpressionStatement' }
  }
}

left matches when visiting BlockStatement - print parents and children:
IfStatement,[BlockStatement] ⚟ [ 'ExpressionStatement' ]
right matches when visiting ExpressionStatement - print parents and children:
IfStatement,BlockStatement,[ExpressionStatement] ⚟ [ 'CallExpression' ] 😱

right is false on BlockStatement. left is false on ExpressionStatement. no match 🔴

compare that to within IfStatement:has(>BlockStatement)

selector {
  type: 'child',
  left: { type: 'exactNode' },
  right: { type: 'identifier', value: 'BlockStatement' }
}

left matches when visiting BlockStatement - print parents and children:
IfStatement,[BlockStatement] ⚟ [ 'ExpressionStatement' ]
right matches when visiting BlockStatement - print parents and children:
IfStatement,[BlockStatement] ⚟ [ 'ExpressionStatement' ]

left && right match on the same node ✔️

But even this doesn't look correct (should be [BlockStatement] ⚟ [ 'ExpressionStatement' ]).
:has injects IfStatement as an ancestor ❓ when checking the insides of :has(>BlockStatement). Then child matches when visiting BlockStatement, and it checks left(ancestry[0], ancestry.slice(1), options):

• ancestry = [IfStatement]
• left = matcher for exactNode
• it checks if IfStatement has no ancestors ❓ not BlockStatement

[lukaw3d]

An attempt to fix it: #148