-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rule types #110
Open
nzakas
wants to merge
2
commits into
main
Choose a base branch
from
types-update-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add rule types #110
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 not a fan of the stylistic config? Any reason in particular to remove this?
From running locally, I see two complaints:
@typescript-eslint/array-type
: purely stylistic for consistency. If you preferArray<...>
that's available as an option.@typescript-eslint/consistent-indexed-object-style
: it's meant to be purely stylistic, but there are some changes between interfaces and records. If you want to use catch-all string signatures the wayRuleVisitor
is set up now, I'd just disable the rule with a comment. Either inline or in the config altogether.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I didn't think either of these warnings were helpful, and I didn't feel like fighting other rules that might come up (generally not a fan of applying rules blindly, especially ones that just seem to be enforcing stylistic preferences that I don't have).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. My (very obviously biased as typescript-eslint maintainer) recommendation would be to keep them enabled, but I understand why you'd want to avoid the stylistic preferences.
The terminology here is unfortunate: "stylistic" as used by that shareable config encompasses more than what "stylistic" means in ESLint core. It contains more than just consistency rules; it also has some real best practice violations and checks for likely bug causing syntax.
I'd recommend at least considering leaving the following rules (here or as a followup issue) that most folks see as definitive positives beyond just stylistic consistency:
@typescript-eslint/adjacent-overload-signatures
@typescript-eslint/no-confusing-non-null-assertion
@typescript-eslint/no-inferrable-types
...and similarly at least considering these rules on "just pick one and stick with it" consistency points that, in my experience, tend to get annoyingly split in a repo over time:
@typescript-eslint/array-type
@typescript-eslint/consistent-type-definitions
https://typescript-eslint.io/rules/?=stylistic-xtypeInformation has the full listing of rules in
tseslint.configs.stylistic
.