Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export internal constructs for other plugin authors #17

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Sidnioulz
Copy link
Contributor

@Sidnioulz Sidnioulz commented Aug 20, 2024

Prerequisites checklist

What is the purpose of this pull request?

Exports internal JSONLanguage and JSONSourceCode classes to allow further specialisation, so that plugins for JSON-based domain-specific languages can reuse that code without copying it.

What changes did you make? (Give an overview)

  • Added named exports to the project index for JSONLanguage and JSONSourceCode

Related Issues

This was requested to the JSON plugin maintainer on Discord. Happy to open an issue for traceability if desired.

Is there anything you'd like reviewers to focus on?

  • Is feat okay as a commit type to use? Or do refactor or chore trigger patch releases?

nzakas
nzakas previously approved these changes Aug 20, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we've still in v0.x, feat is appropriate.

@nzakas
Copy link
Member

nzakas commented Aug 20, 2024

Looks like there's a validation error. Can you run npm run fmt and re-push?

@Sidnioulz
Copy link
Contributor Author

Looks like there's a validation error. Can you run npm run fmt and re-push?

Oops! I'm too used to having this on file save in my IDE for my own projects, forgot to check for it :)

@Sidnioulz Sidnioulz requested a review from nzakas August 20, 2024 20:28
@nzakas nzakas merged commit ad729f0 into eslint:main Aug 20, 2024
15 checks passed
@ipanasenko
Copy link

ipanasenko commented Aug 21, 2024

I think this is exactly what was missing for me, when I tried to write my own json plugin, thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants