fix: Ensure donations don't show up as sponsors #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-sethuraman
previously approved these changes
Sep 6, 2024
fasttime
reviewed
Sep 6, 2024
| @@ -387,7 +397,7 @@ async function fetchGitHubSponsors() { | |||
| const donations = openCollectiveDonations.concat(githubDonations); | |||
|
|
|||
| // sort donations so most recent is first | |||
| donations.sort((a, b) => new Date(a) - new Date(b)); | |||
| donations.sort((a, b) => Date.parse(b.date) - Date.parse(a.date)); | |||
|
Nice catch! I’m nearly done with the changes. Hopefully, this will resolve the issue in other repositories as well. You can track the progress here: #619. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Siemens recently donated $1000 to ESLint through GitHub Sponsors, but it's showing up as a sponsor rather than a donation.
This updates our script to filter out any one-time sponsorships from the sponsors list (these are displayed as individual donations rather than sponsorships).
I also fixed the sorting of donations so that the Open Collective and GitHub donations are sorted in chronological order across both data sets.
Related Issues
Is there anything you'd like reviewers to focus on?