Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent problems with long job argument list #533

Merged
merged 2 commits into from
Jul 15, 2023
Merged

prevent problems with long job argument list #533

merged 2 commits into from
Jul 15, 2023

Conversation

erwindon
Copy link
Owner

some salt command have long arguments lists.

the full argument list was used as the title of the Job page.
this should be shortened to the first 50 characters only.

but when that title is shortened, there is no more insight in the argument list of the command.
therefore, in that case, add the full command at the top of the output panel.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon
Copy link
Owner Author

result:
afbeelding

@erwindon
Copy link
Owner Author

@tazaki fyi

@tazaki
Copy link

tazaki commented Jul 15, 2023

Confirmed this fixes my issue after the patch to app.py [addition from Erwin: see #532 for that]

@erwindon erwindon merged commit 9d089bc into master Jul 15, 2023
5 checks passed
@erwindon erwindon deleted the jobargs branch July 15, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants