Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.7 #2744

Closed
wants to merge 0 commits into from
Closed

Conversation

Pliner
Copy link
Contributor

@Pliner Pliner commented Jun 15, 2023

Summary

Python 3.7 EOL is approaching, this PR removes its support.

Related to #727.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Pliner Pliner changed the title Drop Python 3.7 support Drop support for Python 3.7 Jun 15, 2023
def test_ssl_config_support_for_keylog_file(tmpdir, monkeypatch): # pragma: no cover
if sys.version_info > (3, 8):
Copy link
Contributor Author

@Pliner Pliner Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, this test works for 3.8 as well.

@tomchristie
Copy link
Member

Cool, thanks.

Dug out our discussion on dropping 3.6 to see what factors we used to help our decision here, which reminded me to check out pypi stats...

Screenshot 2023-06-16 at 11 22 53

@T-256
Copy link
Contributor

T-256 commented Jun 16, 2023

Python 3.7 reached EOL, but packages still can support it (it just not accepts new security fixes).
IMO would be better going to deprecation process before direct drop it.
I think <2% of downloads would be good point to complete drop.
According to pypyistats there is still 11% of downloads for py3.7:

image

@Pliner
Copy link
Contributor Author

Pliner commented Jun 27, 2023

@tomchristie @T-256 Then, how is it better to proceed?

To create one more PR with a deprecation warning, release a new version, and wait for the updated statistics for a few months? Or just wait?

@tomchristie
Copy link
Member

3.7 isn't really costing us anything at the moment.

Perhaps we wait until 3.12 is imminent and then consider switching to supporting 3.8, 3.9, 3.10, 3.11, 3.12?

@tomchristie
Copy link
Member

This is starting to impact our CI as other tools switch out... https://github.com/encode/httpx/pulls

Perhaps our next release really should be a 0.25 with Python 3.8+ support?

(Thanks for your patience @Pliner)

@Pliner
Copy link
Contributor Author

Pliner commented Aug 3, 2023

This is starting to impact our CI as other tools switch out... https://github.com/encode/httpx/pulls

Perhaps our next release really should be a 0.25 with Python 3.8+ support?

(Thanks for your patience @Pliner)

+1.

Give me a moment, I will be rebase the PR on top of the latest changes.

@Pliner
Copy link
Contributor Author

Pliner commented Aug 3, 2023

@tomchristie Sorry, I incorrectly rebased this PR from the first attempt and GH closed it :(

#2813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants