(chore) Rename ConsumerSupervisor and Consumer.Supervisor #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetised
reviewed
Sep 5, 2024
There was a problem hiding this comment.
I see a bikeshed! I get the urge to rename, and I like IndividualConsumerSupervisor but ConsumerGroupSupervisor just doesn't work for me, since its a name you could also equally apply to the IndividualConsumerSupervisor...
What about putting Dynamic in the name to point at its role in starting and stopping shape consumers. I dunno, ConsumerDynamicSupervisor or DynamicConsumerSupervisor, Shapes.DynamicSupervisor?
I don't like them much either, so maybe not, but I know ConsumerGroupSupervisor is going to confuse me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames two supervisors with very similar names to avoid confusion:
ConsumerSupervisoris nowConsumerGroupSupervisorConsumer.Supervisoris nowIndividualConsumerSupervisor