elastic · kibanamachine · Sep 19, 2024
diff --git a/packages/kbn-optimizer/src/worker/entry_point_creator.ts b/packages/kbn-optimizer/src/worker/entry_point_creator.ts
@@ -7,9 +7,6 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-// TODO: we should be able to remove this ts-ignore while using isolatedModules
-// this is a skip for the errors created when typechecking with isolatedModules
-// @ts-ignore
 module.exports = function ({
   entries,
 }: {

diff --git a/src/plugins/event_annotation/server/fetch_event_annotations/index.ts b/src/plugins/event_annotation/server/fetch_event_annotations/index.ts
@@ -9,10 +9,6 @@
 
 // TODO: implement this on the server
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 // import { StartServicesAccessor } from '@kbn/core/server';
 // import { EventAnnotationStartDependencies } from '../plugin';
 

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -1982,11 +1982,8 @@
     "useUnknownInCatchVariables": false,
     // enabled to point out not supported features when emitting in an isolated module environment
     "isolatedModules": true,
-    // TODO(jbudz): should be uncommented when upgrading to [email protected]
-    //
     // ensures every non-declaration file is treated as a module
-    // "moduleDetection": "force",
-    //
+    "moduleDetection": "force",
     // disabled for better IDE support, enabled when running the type_check script
     "composite": false,
     // enabled for improved performance

diff --git a/x-pack/plugins/cases/server/common/index.ts b/x-pack/plugins/cases/server/common/index.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 // Careful of exporting anything from this file as any file(s) you export here will cause your functions to be exposed as public.
 // If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
 // than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.

diff --git a/...ns/cross_cluster_replication/public/__jest__/client_integration/mocks/breadcrumbs.mock.ts b/...ns/cross_cluster_replication/public/__jest__/client_integration/mocks/breadcrumbs.mock.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 jest.mock('../../../app/services/breadcrumbs', () => {
   const original = jest.requireActual('../../../app/services/breadcrumbs');
 

diff --git a/...ross_cluster_replication/public/__jest__/client_integration/mocks/track_ui_metric.mock.ts b/...ross_cluster_replication/public/__jest__/client_integration/mocks/track_ui_metric.mock.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 jest.mock('../../../app/services/track_ui_metric', () => {
   const original = jest.requireActual('../../../app/services/track_ui_metric');
 

diff --git a/...board_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.test.tsx b/...board_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.test.tsx
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 // Need to wait for https://github.com/elastic/eui/pull/3173/
 // to unit test this component
 // basic interaction is covered in end-to-end tests

diff --git a/...lications/app_search/components/engines/components/tables/__mocks__/engines_logic.mock.ts b/...lications/app_search/components/engines/components/tables/__mocks__/engines_logic.mock.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 jest.mock('../../..', () => ({
   EnginesLogic: { actions: { deleteEngine: jest.fn() } },
 }));
diff --git a/...ns/fleet/public/components/agent_enrollment_flyout/agent_enrollment_flyout.test.mocks.tsx b/...ns/fleet/public/components/agent_enrollment_flyout/agent_enrollment_flyout.test.mocks.tsx
@@ -6,9 +6,6 @@
  */
 
 import React from 'react';
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
 
 jest.mock('../../hooks', () => {
   return {

diff --git a/x-pack/plugins/index_management/__jest__/client_integration/helpers/mocks.ts b/x-pack/plugins/index_management/__jest__/client_integration/helpers/mocks.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 (window as any).Worker = class Worker {
   onmessage() {}
   postMessage() {}

diff --git a/x-pack/plugins/lists/common/index.ts b/x-pack/plugins/lists/common/index.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 // Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase.
 // If you're using functions/types/etc... internally it's best to import directly from their paths than expose the functions/types/etc... here.
 // You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
diff --git a/x-pack/plugins/osquery/cypress/plugins/index.ts b/x-pack/plugins/osquery/cypress/plugins/index.ts
@@ -21,10 +21,6 @@
 /**
  * @type {Cypress.PluginConfig}
  */
-// TODO: we should be able to remove this ts-ignore while using isolatedModules
-// this is a skip for the errors created when typechecking with isolatedModules
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 module.exports = (on: any, config: any) => {
   // eslint-disable-next-line @typescript-eslint/no-var-requires

diff --git a/x-pack/plugins/rollup/public/test/client_integration/helpers/jest.mocks.tsx b/x-pack/plugins/rollup/public/test/client_integration/helpers/jest.mocks.tsx
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 jest.mock('lodash', () => ({
   ...jest.requireActual('lodash'),
   debounce: (fn: () => unknown) => fn,

diff --git a/x-pack/plugins/security_solution/common/index.ts b/x-pack/plugins/security_solution/common/index.ts
@@ -5,9 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
 export {
   APP_UI_ID,
   APP_ID,

diff --git a/x-pack/plugins/security_solution/public/common/mock/formatted_relative.ts b/x-pack/plugins/security_solution/public/common/mock/formatted_relative.ts
@@ -5,10 +5,6 @@
  * 2.0.
  */
 
-// TODO(jbudz): should be removed when upgrading to [email protected]
-// this is a skip for the errors created when typechecking with isolatedModules
-export {};
-
 jest.mock('@kbn/i18n-react', () => {
   const { i18n } = jest.requireActual('@kbn/i18n');
   i18n.init({ locale: 'en' });