Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consume elasticsearch.publicBaseUrl where possible #192741

Merged
merged 20 commits into from
Sep 19, 2024
Merged

Consume elasticsearch.publicBaseUrl where possible #192741

merged 20 commits into from
Sep 19, 2024

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Sep 12, 2024 •
edited by kibanamachine
Loading

Summary

This actually consumes the public base url in the cloud plugin and the places depending on the elasticsearchUrl value populated there.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 labels Sep 12, 2024
@sphilipse sphilipse marked this pull request as ready for review September 17, 2024 14:16
@sphilipse sphilipse requested review from a team as code owners September 17, 2024 14:16
criamico
criamico approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet LGTM

sabarasaba
sabarasaba approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index management changes lgtm

afharo
afharo approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just added a few comments for me to familiarize myself with this code and with some minor suggestions.

x-pack/plugins/cloud/common/constants.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/server/routes/elasticsearch_routes.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/server/routes/elasticsearch_routes.ts Outdated Show resolved Hide resolved
x-pack/plugins/cloud/public/types.ts Show resolved Hide resolved
@sphilipse sphilipse enabled auto-merge (squash) September 18, 2024 14:57
@sphilipse sphilipse added the backport:prev-major Backport to the previous major branch and all later branches still in development label Sep 19, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Fleet Cypress Tests #4 / View agents list Agent status filter should filter on healthy (16 result)
  • [job] [logs] Fleet Cypress Tests #4 / View agents list Agent status filter should filter on healthy and unhealthy
  • [job] [logs] Fleet Cypress Tests #4 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +448.0B
fleet 1.8MB 1.8MB +122.0B
home 151.9KB 152.0KB +53.0B
indexManagement 682.3KB 682.3KB +45.0B
searchHomepage 54.8KB 54.8KB +53.0B
searchIndices 83.1KB 83.3KB +196.0B
searchPlayground 151.1KB 151.2KB +84.0B
serverlessSearch 326.9KB 327.2KB +368.0B
total +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
cloud 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 7.1KB 7.6KB +464.0B
cloudLinks 30.1KB 30.2KB +53.0B
total +517.0B
Unknown metric groups

API count

id before after diff
@kbn/core-elasticsearch-server 117 118 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit b4a7b2e into elastic:main Sep 19, 2024
29 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
@sphilipse
Consume elasticsearch.publicBaseUrl where possible (elastic#192741)
9f3e11c 
## Summary

This actually consumes the public base url in the cloud plugin and the
places depending on the `elasticsearchUrl` value populated there.

---------

Co-authored-by: Rodney Norris <[email protected]>
(cherry picked from commit b4a7b2e)
@kibanamachine kibanamachine mentioned this pull request Sep 19, 2024
Open
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 192741

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@afharo afharo afharo approved these changes

@criamico criamico criamico approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to the previous major branch and all later branches still in development release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sphilipse @kibana-ci @kibanamachine @sabarasaba @TattdCodeMonkey @afharo @criamico