Remove SDK Workload from Aspire 9.0 #5773
Draft
+47
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
requested review from
radical,
eerhardt,
mitchdenny and
ReubenBond
as code owners
joperezr
commented
Sep 18, 2024
| @@ -10,7 +10,7 @@ | |||
| <SkipEventHubsEmulation Condition="'$(SkipEventHubsEmulation)' == '' and ('$(RepoRoot)' == '' or '$(ContinuousIntegrationBuild)' == 'true' or '$(CODESPACES)' == 'true')">true</SkipEventHubsEmulation> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(IsAspireHost)' == 'true' and '$(SkipDashboardProjectReference)' != 'true'"> | |||
| <ItemGroup Condition="$(MSBuildProjectName.EndsWith('AppHost')) and '$(SkipDashboardProjectReference)' != 'true'"> | |||
There was a problem hiding this comment.
Can we make the Aspire.Hosting.AppHost package add something, e.g. property or project capability, to make conditions like a bit more concrete?
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <IsAspireHost>true</IsAspireHost> |
There was a problem hiding this comment.
Are we confident nothing is relying on this property to be set to enable certain behaviors, e.g. in Visual Studio? Hopefully they're all using the project capability which is still added by the SDK but figured we should verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still Work-in-progress and not ready for review
Description
One of the goals for Aspire 9.0 is to no longer require an SDK Workload to be installed in order to create/build/run .NET Aspire applications, especially given after 8.2.0 all it has is the .NET Aspire templates (which can also be inserted into Visual Studio or installed separately) and the Aspire.Hosting.SDK (which could also just be an SDK reference in AppHost projects). Given that, with Aspire 9.0 we are no longer planning to ship a workload, and instead just slightly modify how the AppHost projects reference the SDK in order to allow consumers to build and run applications without needing to install a workload.
This PR contains the required changes to the templates, as well as it removes the production of the Aspire workload and deals with all of the fallout from that. The goal is to merge this in time for .NET Aspire's 9.0 RC1 release later this month, so that we can better test and ensure everything is working as expected.
cc: @radical @eerhardt @DamianEdwards @maddymontaquila @mitchdenny @davidfowl
Fixes #5444
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow