Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for trace filters UI in the dashboard #5751

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 17, 2024

Structured logs support advanced filtering by tags. This PR adds similar functionality to distributed tracing

  • Add filters UI to traces page
  • Reuses FilterDialog. The dialog has been updated to be reused from both screens
  • Adds tests to telemetry repository for filtering by tags

Fixes #5100

Demo:
trace-filters

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Sep 18, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member

@radical Why don't we get a dump on test timeouts:

 Aborting test run: test run timeout of 1200000 milliseconds exceeded.
  Aborting test run: test run timeout of 1200000 milliseconds exceeded.
  Results File: /datadisks/disk1/work/B7A10A6D/w/AECC0994/uploads/logs/TestResults.trx
  
  Test Run Aborted.
  Total tests: Unknown
       Passed: 20
   Total time: 20.0316 Minutes
/datadisks/disk1/work/B7A10A6D/w/AECC0994/e/tests/Aspire.Playground.Tests/bin/Debug/net8.0/Aspire.Playground.Tests.dll : error TESTRUNABORT: Test Run Aborted. [/datadisks/disk1/work/B7A10A6D/w/AECC0994/e/tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj]

@davidfowl
Copy link
Member

Instead of using xunit test timeouts maybe we should use dotnet test timeouts.

@radical
Copy link
Member

radical commented Sep 18, 2024

@radical Why don't we get a dump on test timeouts:

 Aborting test run: test run timeout of 1200000 milliseconds exceeded.
  Aborting test run: test run timeout of 1200000 milliseconds exceeded.
  Results File: /datadisks/disk1/work/B7A10A6D/w/AECC0994/uploads/logs/TestResults.trx
  
  Test Run Aborted.
  Total tests: Unknown
       Passed: 20
   Total time: 20.0316 Minutes
/datadisks/disk1/work/B7A10A6D/w/AECC0994/e/tests/Aspire.Playground.Tests/bin/Debug/net8.0/Aspire.Playground.Tests.dll : error TESTRUNABORT: Test Run Aborted. [/datadisks/disk1/work/B7A10A6D/w/AECC0994/e/tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj]

We were getting it earlier. We pass --blame-crash --blame-crash-dump-type full to the test command. Maybe something broke in the update to the 9.0 tooling.

@radical
Copy link
Member

radical commented Sep 18, 2024

Also, I think the playground tests are now running close to 20mins, so might be a good time to split that into multiple helix jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom filtering by attributes in Traces
3 participants