Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitFor: SQL Server #5669

Merged
merged 17 commits into from
Sep 12, 2024
Merged

WaitFor: SQL Server #5669

merged 17 commits into from
Sep 12, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 10, 2024

Description

Adds SQL Server support for WaitFor (still needs unit tests and some validation around Azure SQL deployments).

Related: #5645

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Sep 10, 2024
@mitchdenny mitchdenny added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 10, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Sep 10, 2024
@mitchdenny mitchdenny marked this pull request as ready for review September 11, 2024 10:39
@radical
Copy link
Member

radical commented Sep 12, 2024

In a separate PR we should add the WaitForSandbox playground app to the tests too.

@davidfowl
Copy link
Member

davidfowl commented Sep 12, 2024

@danegsta

Aspire.Hosting.Dcp.dcpctrl.NetworkReconciler Error: could not create a network {"NetworkName": {"name":"aspire-network"}, "Reconciliation": 2, "error": "docker command 'CreateNetwork' returned with non-zero exit code 1: command output: Stdout: '' Stderr: 'Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network\n'"}

Seems like we're not cleaning up the network properly?

https://stackoverflow.com/questions/43720339/docker-error-could-not-find-an-available-non-overlapping-ipv4-address-pool-am

@mitchdenny
Copy link
Member Author

@radical I reverted the target framework changes. None of the other sames seem to have that.

@mitchdenny
Copy link
Member Author

Oh they do on main now. I'm going to merge with main.

@davidfowl davidfowl merged commit 62eb540 into main Sep 12, 2024
11 checks passed
@davidfowl davidfowl deleted the mitchdenny/wait-for-sql-server branch September 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants