Skip to content

Commit

Permalink
Add override keyword to make it more explicit. (#683)
Browse files Browse the repository at this point in the history
Co-authored-by: Philip Hyunsu Cho <[email protected]>
  • Loading branch information
AtomicVar and hcho3 committed Jun 7, 2024
1 parent 3031e4a commit 1ef6649
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions include/dmlc/threadediter.h
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ class ThreadedIter : public DataIter<DType> {
* use the other Next instead
* \return true if there is next record, false if we reach the end
*/
virtual bool Next(void) {
virtual bool Next(void) override {
if (out_data_ != NULL) {
this->Recycle(&out_data_);
}
Expand All @@ -199,12 +199,12 @@ class ThreadedIter : public DataIter<DType> {
* NOTE: the call to this function is not threadsafe
* use the other Next instead
*/
virtual const DType &Value(void) const {
virtual const DType &Value(void) const override {
CHECK(out_data_ != NULL) << "Calling Value at beginning or end?";
return *out_data_;
}
/*! \brief set the iterator before first location */
virtual void BeforeFirst(void) {
virtual void BeforeFirst(void) override {
ThrowExceptionIfSet();
std::unique_lock<std::mutex> lock(mutex_);
if (out_data_ != NULL) {
Expand Down

0 comments on commit 1ef6649

Please sign in to comment.