DEV: update plugin and theme workflows to support both yarn & pnpm #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
commented
Sep 19, 2024
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| cache: yarn | ||
| cache: ${{ steps.js-pkg-manager.outputs.manager }} |
There was a problem hiding this comment.
probably not necessary if we are simply building direct with pnpm instead of having the step to restore from cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change to prepare for all officially supported plugins & themes to switch over to using
pnpm.Once all such plugins & themes are converted, we will remove references to yarn in these workflows and increment VERSION.
See https://meta.discourse.org/t/324521 for more detail on this change.
In the pnpm flow, we don't need to pull from github's cache for a restore of previous builds as it's overall slower than directly installing via pnpm.
Testing
WIP