Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jnf/fyst 461 #4727

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Jnf/fyst 461 #4727

wants to merge 5 commits into from

Conversation

jnf
Copy link
Contributor

@jnf jnf commented Aug 30, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Explain the implementation goals being solved or the feature with the reviewer in mind
  • Mention any relevant issues or insights to be shared with the reviewer.
  • Alternatives considered

How to test?

  • In an environment where you can download the submission bundle...
  • Generate and submit a state return
  • Download and unzip the submitted bundle
  • Verify it includes 3 files: manifest/manifest.xml, xml/submission.xml, and (new) irs/xml/federalreturn.xml.
  • Verify the downloaded federalreturn.xml is an identical copy of the XML provided by doing the Direct File import to begin the intake.
  • This should be true for all supported states.

Risk Assessment

  • More data in the bundle means longer times to generate/submit and large file size to transmit. It's not a huge increase, but we should monitor for changes to the completion time and memory footprint for the relevant endpoints/requests.

Screenshots (for visual changes)

  • n/a

Copy link

Heroku app: https://gyr-review-app-4727-639f7045d881.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4727 (optionally add --tail)

@mpidcock mpidcock added the wip denotes a work in progress that isn't ready for formal review label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip denotes a work in progress that isn't ready for formal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants