chore: Align Change Sets for 1.0.0 release #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
![codecov[bot]](https://avatars.githubusercontent.com/in/254?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes denote an important transition of a set of plugins to major versions, indicating some significant updates. It's also noticeable that the mode is being switched from 'pre' to 'exit'. However, I couldn't find any changes related to the version bump in the presented diff. It would be helpful to review these changes in addition to the alterations in the mode and version declarations.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "mode": "pre", | |||
| "mode": "exit", | |||
There was a problem hiding this comment.
You have changed the mode from 'pre' to 'exit'. It's hard to determine the consequences of this change without knowing how this mode is used. Ensure that other parts of your application are able to properly handle this updated mode.
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| "@codecov/bundler-plugin-core": major | |||
There was a problem hiding this comment.
You have listed multiple packages as 'major' in the changeset metadata. If this is accurately reflecting the changes that have been made to these packages, that's fine. However, make sure that you are following semantic versioning guidelines and that these updates truly warrant a major version increment.
.changeset/shiny-ghosts-play.md
Outdated
| "@codecov/webpack-plugin": major | ||
| --- | ||
|
|
||
| Release 1.0.0 of the plugins |
There was a problem hiding this comment.
This change summary isn't descriptive enough about what exactly has been modified in this new release. While it's clear that it's a considerable release of the plugins with version 1.0.0, it would be beneficial to summarize briefly what new features or major changes are included in this release.
There was a problem hiding this comment.
I assume this is what will show up in https://github.com/codecov/codecov-javascript-bundler-plugins/releases, so let's add those extra docs as the bot says.
- Link to codecov marketing/docs
- Talk about what it supports atm
There was a problem hiding this comment.
I'll update this, but I may have gone a bit too far in MD formatting. So I'll run a pre-publish to see what the result looks like before merging.
There was a problem hiding this comment.
Okay I think i got everything working alright
Bundle ReportChanges will increase total bundle size by 445.36kB ⬆️
|
Bundle ReportChanges will decrease total bundle size by 29.16kB (-0.51%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
.changeset/shiny-ghosts-play.md
Outdated
| "@codecov/webpack-plugin": major | ||
| --- | ||
|
|
||
| Release 1.0.0 of the plugins |
There was a problem hiding this comment.
I assume this is what will show up in https://github.com/codecov/codecov-javascript-bundler-plugins/releases, so let's add those extra docs as the bot says.
- Link to codecov marketing/docs
- Talk about what it supports atm
.changeset/shiny-ghosts-play.md
Outdated
| "@codecov/webpack-plugin": major | ||
| --- | ||
|
|
||
| Release 1.0.0 of the plugins. You can read more about the plugins in our [docs](https://docs.codecov.com/docs/javascript-bundle-analysis). |
There was a problem hiding this comment.
Ensure that all these plugins are well-documented and each major change is described sufficiently in the documentation pointed at by this link.
|
|
||
| The plugins have the following functionality: | ||
|
|
||
| - Automatically collect and upload bundle stats data to Codecov |
There was a problem hiding this comment.
This functionality seems beneficial, but make sure that implementing this feature doesn't violate any user's privacy or security principles.
.changeset/shiny-ghosts-play.md
Outdated
|
|
||
| - Automatically collect and upload bundle stats data to Codecov | ||
| - Tokenless uploads of bundle stats for forked upstream pull requests | ||
| - GH OIDC authentication for users or organizations who have configured it with GitHub |
There was a problem hiding this comment.
Ensure the authentication flows are vigorously tested and secure from potential breaches.
nicholas-codecov
deleted the
gh-eng-2440-2441-exit-pre-and-move-to-one-dot-o
branch
Description
This PR sets everything up for the
1.0.0release of the plugins, adding in a major release as well as exiting pre-mode. Here is an example after runningprepare-publishensuring that everything is working as expected with changeset: #165