[feat] Add SolidStart plugin support #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 3.86kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 83.64kB ⬆️
|
rohitvinnakota-codecov
changed the title
There was a problem hiding this comment.
Can you remove this file, it's created when the build failed in the bundler iirc.
| afterEach(async () => { | ||
| await $`rm -rf ${solidStartApp}/app.config.ts`; | ||
| await $`rm -rf ${solidStartApp}/.solid-start`; | ||
| await $`rm -rf ${solidStartApp}/app.config.ts.timestamp-*`; |
There was a problem hiding this comment.
Looks like this needs to be updated to match the ones you have committed from this directory.
…m/codecov/codecov-javascript-bundler-plugins into rvinnakota/add-solidstart-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds solidstart support to the project. SolidJS extends Vite.
This PR closes #98
Some notes on configuring vite with solid.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.