Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the FlakeAggregates GQL model #821

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Sep 12, 2024

This contains the flakeCount and flakeRate fields.

The flakeCount is calculated by getting all flakes that are active or ended in the last 30 days

The flakeRate is calculated by accumulating the flaky_fail_count / (pass_count + fail_count) for all tests

depends on: codecov/shared#356 and #816

this commit also adds the LastDuration field to the TestResult
GQL model. The reason we're using latest_run and not the updated_at
field of the object is because in the future we want to parse the
timestamp from the JUnit XML file so latest_run will be tied to that
and not the time at which we process the test results.
- TestResultsHeaders represents the information displayed in the Test
Analytics UI that is related to test results, total duration of tests,
accumulated duration of the 5% slowest tests, total number of failures,
and total number of skips

- a field of type TestResultsHeaders was added to the Repository model
- rename the TestResultsHeaders GQL model to TestResultsAggregates
- create the FlakeAggregates that contains flakeCount and flakeRate
  and uses the flaky_failure_count field from the DailyTestRollup
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (e8d8cd0) to head (d2dead6).
Report is 6 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@               Coverage Diff                @@
##               main       #821        +/-   ##
================================================
- Coverage   96.22000   95.88000   -0.34000     
================================================
  Files           812        758        -54     
  Lines         18538      15670      -2868     
================================================
- Hits          17839      15025      -2814     
+ Misses          699        645        -54     
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant