bundle analysis: assets can fetch true gzip size #642
Conversation
| @@ -20,7 +20,7 @@ factory-boy | |||
| fakeredis | |||
| freezegun | |||
| https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem | |||
There was a problem hiding this comment.
To be updated to the latest shared commit on main once the PR is merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 621 621
Lines 16555 16569 +14
=======================================
+ Hits 15156 15170 +14
Misses 1399 1399
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 91.54% 91.55%
=======================================
Files 621 621
Lines 16555 16569 +14
=======================================
+ Hits 15156 15170 +14
Misses 1399 1399
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
================================================
+ Coverage 95.94000 95.95000 +0.01000
================================================
Files 799 799
Lines 17872 17886 +14
================================================
+ Hits 17148 17162 +14
Misses 724 724
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
closes codecov/engineering-team#1928
Fetch the actual asset gzip size from the bundle report instead of guessing its value. Also refactor the BundleData object a bit, so that it can be deleted soon because we won't need it.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.