Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator check in browser-like(but not browser) environments #151

Closed
wants to merge 1 commit into from

Conversation

adgang
Copy link

@adgang adgang commented Aug 31, 2023

This helps prevent errors like:

ReferenceError: navigator is not defined

in environments where navigator does not exist but has polyfills and might look like browser to libraries.

if (brand?.version > 93) {
return 3;
if (typeof navigator !== 'undefined') {
if (navigator.userAgentData) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do this instead the if.

Suggested change
if (navigator.userAgentData) {
if (globalThis.navigator?.userAgentData) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants