Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript coverage #475

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Jan 3, 2023

Summary:

Removes all // @ts-ignore directives and one use of any from the codebase.

Remaining issues

This PR leaves one any (related to a genuinely unsafe use of a forwarded ref) and one cast through unknown (required by the use of findDOMNode). These are likely fixable, but the fixes might be more invasive than the others here, which are mostly limited to type-level changes.

Test Plan:

Ran npx tsc in package, example, and example-web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant