Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve normalized stack bar performance #2699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

panthony
Copy link
Contributor

I had a huge performance regression for normalized stack bar when I have a thousand bar and ~10 series.

It makes the browser hang for a while, stuck in 'filterTargetsToShow' mainly.

When I investigated I found that:

  • the calls to 'api.data.shown' seems unnecessary.
  • we normalized values for a lot of unnecessary targets. Like a LOT, coupled with the fact that 'filterTargetsToShow' were copying the targets it had a huge hit

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #2699 into master will decrease coverage by 0.04%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.05%     
==========================================
  Files          59       59              
  Lines        4718     4724       +6     
==========================================
+ Hits         3901     3904       +3     
- Misses        817      820       +3
Impacted Files Coverage Δ
src/shape.js 95.52% <100%> (+0.13%) ⬆️
src/data.js 88.34% <83.33%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dcd65...115cb29. Read the comment docs.

@panthony panthony marked this pull request as ready for review September 17, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants