Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure innerRadius is not NaN value #2631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

arnsvel
Copy link

@arnsvel arnsvel commented Jun 13, 2019

Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.

Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN

Error: attribute dx: Expected length, "NaNpx".
Replication:
Happens every time lost focus from/to browser tab when gauge chart is dynamically generated.

Investigation:
w = config.gauge_width is has assigned value 10
$$.innerRadiusRatio is -Infinity
$$.innerRadius is NaN
@codecov-io
Copy link

Codecov Report

Merging #2631 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
+ Coverage   80.15%   80.16%   +<.01%     
==========================================
  Files          57       57              
  Lines        4516     4517       +1     
==========================================
+ Hits         3620     3621       +1     
  Misses        896      896
Impacted Files Coverage Δ
src/arc.js 74.04% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...b65ad6d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #2631 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
+ Coverage   80.15%   80.16%   +<.01%     
==========================================
  Files          57       57              
  Lines        4516     4517       +1     
==========================================
+ Hits         3620     3621       +1     
  Misses        896      896
Impacted Files Coverage Δ
src/arc.js 74.04% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361534...b65ad6d. Read the comment docs.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this! one comment.

@@ -492,7 +492,8 @@ ChartInternal.prototype.redrawArc = function (duration, durationForExit, withTra
backgroundArc
.exit()
.remove();


$$.innerRadius = $$.innerRadius || 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a right place to do this. How about checking this in updateRadius?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants