Restore the check for missing adblock manifests when packaging #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only directories with a `manifest.json` were considered for packaging. Now we look at the list catalog as the source of truth, but we still need to skip components that were not correctly handled in a previous step. This should be rectified later by combining the data-files, manifests, and packaging step into the same pipeline per-component.
ShivanKaul
reviewed
Feb 15, 2024
| @@ -54,6 +54,12 @@ const processComponent = (binary, endpoint, region, keyDir, | |||
| const parsedManifest = util.parseManifest(originalManifest) | |||
| const id = util.getIDFromBase64PublicKey(parsedManifest.key) | |||
|
|
|||
| // TODO - previous download failures should prevent the attempt to package the component. | |||
| if (!fs.existsSync(originalManifest)) { | |||
| console.warn(`Missing manifest for ${componentSubdir}. Skipping.`) | |||
There was a problem hiding this comment.
Shouldn't we still report this via Sentry?
There was a problem hiding this comment.
The only way this happens so far is if there was a previous failure reported by Sentry. Long-term, I wouldn't be comfortable leaving it this way... but in the short term before #844 (which is basically ready), there's no need to have duplicate Sentry notifications every time.
ShivanKaul
approved these changes
Feb 15, 2024
linhkikuchi
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only directories with a
manifest.jsonwere considered for packaging. Now we look at the list catalog as the source of truth, but we still need to skip components that were not correctly handled in a previous step.This would have been avoided by #844 which combines download, manifest generation, and packaging into one abortable function call per-component.